Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH wireless-drivers] rtlwifi: rtl8723ae: Fix missing break in switch statement | Date | Tue, 16 Apr 2019 06:36:46 +0300 |
| |
"Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> Add missing break statement in order to prevent the code from falling > through to case 0x1025, and erroneously setting rtlhal->oem_id to > RT_CID_819X_ACER when rtlefuse->eeprom_svid is equal to 0x10EC and > none of the cases in switch (rtlefuse->eeprom_smid) match. > > This bug was found thanks to the ongoing efforts to enable > -Wimplicit-fallthrough. > > Fixes: 238ad2ddf34b ("rtlwifi: rtl8723ae: Clean up the hardware info routine") > Cc: stable@vger.kernel.org > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
You have marked this for wireless-drivers but the commit is 2.5 years old, so I think wireless-drivers-next is more approriate.
-- Kalle Valo
| |