Messages in this thread | | | From | Dan Williams <> | Date | Fri, 12 Apr 2019 12:12:49 -0700 | Subject | Re: [PATCH 1/3] mm/memremap: Rename and consolidate SECTION_SIZE |
| |
On Fri, Apr 12, 2019 at 11:57 AM Robin Murphy <robin.murphy@arm.com> wrote: > > Trying to activatee ZONE_DEVICE for arm64 reveals that memremap's
s/activatee/activate/
> internal helpers for sparsemem sections conflict with and arm64's > definitions for hugepages, which inherit the name of "sections" from > earlier versions of the ARM architecture. > > Disambiguate memremap (and now HMM too) by propagating sparsemem's PA_ > prefix, to clarify that these values are in terms of addresses rather > than PFNs (and because it's a heck of a lot easier than changing all the > arch code). SECTION_MASK is unused, so it can just go.
Looks good to me. So good that it collides with a similar change in the "sub-section" support series.
Acked-by: Dan Williams <dan.j.williams@intel.com>
| |