Messages in this thread | | | Subject | Re: [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority | From | Enric Balletbo i Serra <> | Date | Fri, 12 Apr 2019 11:23:19 +0200 |
| |
Hi,
On 12/4/19 3:27, Brian Norris wrote: > On Wed, Apr 3, 2019 at 1:32 PM Douglas Anderson <dianders@chromium.org> wrote: >> +static int cros_ec_xfer_high_pri(struct cros_ec_device *ec_dev, >> + struct cros_ec_command *ec_msg, >> + cros_ec_xfer_fn_t fn) >> +{ >> + struct cros_ec_xfer_work_params params; >> + >> + INIT_WORK(¶ms.work, cros_ec_xfer_high_pri_work); > > Sorry for the late review, but this should have been > INIT_WORK_ONSTACK(). Should it be a new patch, or is this in a > non-rebasing tree yet? >
No need to resend, I'll do the modification myself and push again.
Thanks, Enric
> Otherwise, looks fine to me: > > Reviewed-by: Brian Norris <briannorris@chromium.org> >
| |