Messages in this thread | | | Date | Fri, 12 Apr 2019 10:38:19 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH 1/2] regmap: soundwire: fix Kconfig select/depend issue |
| |
On Thu, 11 Apr 2019 21:28:13 +0200, Pierre-Louis Bossart wrote: > > The mechanism should be > > config CODEC_XYX_SDW > depends on SOUNDWIRE > select REGMAP_SOUNDWIRE > > config REGMAP_SOUNDWIRE > depends on SOUNDWIRE > select SOUNDWIRE_BUS
To be noted, in general you can't do put both depends-on and select. The select always wins. So the depends-on in REGMAP_SOUNDWIRE is more or less moot.
thanks,
Takashi
> SOUNDWIRE_BUS can be independently selected by the SOC driver. The SOC > driver should not know or care about REGMAP_SOUNDWIRE. > > Fixes: 7c22ce6e2184 ('03fc8746f7915b5a391d8227f7e1') > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > drivers/base/regmap/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig > index 6ad5ef48b61e..4e422afe3c0d 100644 > --- a/drivers/base/regmap/Kconfig > +++ b/drivers/base/regmap/Kconfig > @@ -44,7 +44,8 @@ config REGMAP_IRQ > > config REGMAP_SOUNDWIRE > tristate > - depends on SOUNDWIRE_BUS > + depends on SOUNDWIRE > + select SOUNDWIRE_BUS > > config REGMAP_SCCB > tristate > -- > 2.17.1 >
| |