lkml.org 
[lkml]   [2019]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry
    From
    Date
    On 19. 4. 4. 오후 11:17, Yue Haibing wrote:
    > From: YueHaibing <yuehaibing@huawei.com>
    >
    > As Hans de Goede pointed, using this driver without ACPI
    > makes little sense, so add ACPI dependency to Kconfig entry
    > to fix a build error while CONFIG_ACPI is not set.
    >
    > drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
    > drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type
    > put_device(&adev->dev);
    >
    > Fixes: 0cf064db948a ("extcon: axp288: Convert to use acpi_dev_get_first_match_dev()")
    > Reported-by: Hulk Robot <hulkci@huawei.com>
    > Suggested-by: Hans de Goede <hdegoede@redhat.com>
    > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    > ---
    > v2: rework patch
    > ---
    > drivers/extcon/Kconfig | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
    > index 1ed4b45..de06faf 100644
    > --- a/drivers/extcon/Kconfig
    > +++ b/drivers/extcon/Kconfig
    > @@ -30,7 +30,7 @@ config EXTCON_ARIZONA
    >
    > config EXTCON_AXP288
    > tristate "X-Power AXP288 EXTCON support"
    > - depends on MFD_AXP20X && USB_SUPPORT && X86
    > + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
    > select USB_ROLE_SWITCH
    > help
    > Say Y here to enable support for USB peripheral detection
    >

    Applied it. Thanks.

    --
    Best Regards,
    Chanwoo Choi
    Samsung Electronics

    \
     
     \ /
      Last update: 2019-04-12 01:30    [W:6.304 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site