lkml.org 
[lkml]   [2019]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] firmware: arm_scmi: check return value of idr_find
On Mon, Mar 25, 2019 at 03:48:22PM -0500, Kangjie Lu wrote:

You should mark this v2 id you changed any code or commit message or
added any tags. Just FYI for future.

> Thanks for Steven Price's review of this patch. In the current code,
> idr_find won't return NULL because the SCMI_PROTOCOL_BASE id must
> exist. However, it might return NULL in the future code if the check
> is on another node while processing the children in subsequent calls
> to scmi_mbox_chan_setup().

I don't understand the reference here to future code here. If you have
out of tree code that results in such a scenario, please share or
provide the details on that.

As I mentioned in previous mail, I would bail out much earlier if
SCMI_PROTOCOL_BASE is not allocated IDR and not reach to this point.
We continue even if scmi_create_protocol_device fails for few child
devices.

--
Regards,
Sudeep

\
 
 \ /
  Last update: 2019-04-10 18:32    [W:0.047 / U:1.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site