lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 048/131] hid-sensor-hub.c: fix wrong do_div() usage
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 8d43b49e7e0070f96ac46d30659a336c0224fa0b ]

    do_div() must only be used with a u64 dividend.

    Signed-off-by: Nicolas Pitre <nico@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hid/hid-sensor-hub.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
    index 92870cdb52d9..8efaa88329aa 100644
    --- a/drivers/hid/hid-sensor-hub.c
    +++ b/drivers/hid/hid-sensor-hub.c
    @@ -218,7 +218,8 @@ int sensor_hub_set_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
    goto done_proc;
    }

    - remaining_bytes = do_div(buffer_size, sizeof(__s32));
    + remaining_bytes = buffer_size % sizeof(__s32);
    + buffer_size = buffer_size / sizeof(__s32);
    if (buffer_size) {
    for (i = 0; i < buffer_size; ++i) {
    hid_set_field(report->field[field_index], i,
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-04-01 19:46    [W:2.129 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site