lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/7] ARM: dts: sun8i: tbs-a711: Add node for BMA250 accelerometer
    Hi,

    On Wed, Mar 27, 2019 at 01:18:38AM +0100, megous@megous.com wrote:
    > From: Ondrej Jirman <megous@megous.com>
    >
    > A711 tablet has BMA250 accelerometer connected to I2C1 bus. Enable
    > both the I2C1 bus and add the accelerometer device to it.
    >
    > Signed-off-by: Ondrej Jirman <megous@megous.com>
    > ---
    > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 15 +++++++++++++++
    > 1 file changed, 15 insertions(+)
    >
    > diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
    > index 6aae70c89a1e..347fc0c31fa4 100644
    > --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
    > +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
    > @@ -156,6 +156,21 @@
    > status = "okay";
    > };
    >
    > +&i2c1 {
    > + pinctrl-names = "default";
    > + pinctrl-0 = <&i2c1_pins>;

    It's there already

    > + clock-frequency = <400000>;
    > + status = "okay";
    > +
    > + /* Accelerometer */
    > + bma250@18 {

    The node name should be the class of the device, not its model, so
    something like accelerometer.

    Maxime

    --
    Maxime Ripard, Bootlin
    Embedded Linux and Kernel engineering
    https://bootlin.com
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2019-04-01 08:31    [W:8.991 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site