lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 032/134] tun: add a missing rcu_read_unlock() in error path
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eric Dumazet <edumazet@google.com>

    commit 9180bb4f046064dfa4541488102703b402bb04e1 upstream.

    In my latest patch I missed one rcu_read_unlock(), in case
    device is down.

    Fixes: 4477138fa0ae ("tun: properly test for IFF_UP")
    Signed-off-by: Eric Dumazet <edumazet@google.com>
    Reported-by: syzbot <syzkaller@googlegroups.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/tun.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/tun.c
    +++ b/drivers/net/tun.c
    @@ -1915,6 +1915,7 @@ drop:
    rcu_read_lock();
    if (unlikely(!(tun->dev->flags & IFF_UP))) {
    err = -EIO;
    + rcu_read_unlock();
    goto drop;
    }


    \
     
     \ /
      Last update: 2019-04-01 19:16    [W:6.383 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site