lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 079/146] tty: mxs-auart: fix a potential NULL pointer dereference
    Date
    5.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Kangjie Lu <kjlu@umn.edu>

    commit 6734330654dac550f12e932996b868c6d0dcb421 upstream.

    In case ioremap fails, the fix returns -ENOMEM to avoid NULL
    pointer dereferences.
    Multiple places use port.membase.

    Signed-off-by: Kangjie Lu <kjlu@umn.edu>
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/tty/serial/mxs-auart.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/tty/serial/mxs-auart.c
    +++ b/drivers/tty/serial/mxs-auart.c
    @@ -1686,6 +1686,10 @@ static int mxs_auart_probe(struct platfo

    s->port.mapbase = r->start;
    s->port.membase = ioremap(r->start, resource_size(r));
    + if (!s->port.membase) {
    + ret = -ENOMEM;
    + goto out_disable_clks;
    + }
    s->port.ops = &mxs_auart_ops;
    s->port.iotype = UPIO_MEM;
    s->port.fifosize = MXS_AUART_FIFO_SIZE;

    \
     
     \ /
      Last update: 2019-04-01 19:09    [W:3.518 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site