Messages in this thread | | | Date | Mon, 1 Apr 2019 18:58:47 +0200 | From | Cornelia Huck <> | Subject | Re: [PATCHv1 1/7] vfio/mdev: Avoid release parent reference during error path |
| |
On Tue, 26 Mar 2019 22:45:39 -0500 Parav Pandit <parav@mellanox.com> wrote:
> During mdev parent registration in mdev_register_device(), > if parent device is duplicate, it releases the reference of existing > parent device. > This is incorrect. Existing parent device should not be touched. > > Fixes: 7b96953bc640 ("vfio: Mediated device Core driver") > Reviewed By: Kirti Wankhede <kwankhede@nvidia.com>
Should probably be changed to the canonical Reviewed-by:.
> Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com> > Signed-off-by: Parav Pandit <parav@mellanox.com> > --- > drivers/vfio/mdev/mdev_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index b96fedc..1299d2e 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -181,6 +181,7 @@ int mdev_register_device(struct device *dev, const struct mdev_parent_ops *ops) > /* Check for duplicate */ > parent = __find_parent_device(dev); > if (parent) { > + parent = NULL; > ret = -EEXIST; > goto add_dev_err; > }
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
| |