Messages in this thread | | | Subject | Re: [PATCH v6 1/2] Bluetooth: hci_qca: Added support for WCN3998 | From | Marc Gonzalez <> | Date | Mon, 1 Apr 2019 18:16:18 +0200 |
| |
On 27/03/2019 13:28, Harish Bandi wrote:
> +bool qca_is_wcn399x(enum qca_btsoc_type soc_type) > +{ > + if ((soc_type == QCA_WCN3990) || (soc_type == QCA_WCN3998)) > + return true; > + > + return false; > +}
Dunno if you saw my earlier comment.
The above is not very idiomatic. I would write:
bool is_qca_soc_type_wcn399x_family(enum qca_btsoc_type soc_type) { return soc_type == QCA_WCN3990 || soc_type == QCA_WCN3998; }
Regards.
| |