lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: musb: Silence error about blacklisting hubs if !CONFIG_USB
On Tue, Mar 19, 2019 at 02:51:46PM +0100, Paul Cercueil wrote:
> Some drivers, like jz4740-musb, don't depend on CONFIG_USB.

CONFIG_USB_OTG_BLACKLIST_HUB is about hub, so should it depend on
CONFIG_USB instead in drivers/usb/core/Kconfig?

>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/usb/musb/musb_core.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index b7d56272f9d1..9f5a4819a744 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1497,10 +1497,11 @@ static int musb_core_init(u16 musb_type, struct musb *musb)
> } else {
> musb->is_multipoint = 0;
> type = "";
> -#ifndef CONFIG_USB_OTG_BLACKLIST_HUB
> - pr_err("%s: kernel must blacklist external hubs\n",
> - musb_driver_name);
> -#endif
> + if (IS_ENABLED(CONFIG_USB) &&
> + !IS_ENABLED(CONFIG_USB_OTG_BLACKLIST_HUB)) {
> + pr_err("%s: kernel must blacklist external hubs\n",
> + musb_driver_name);
> + }
> }
>
> /* log release info */

Regards,
-Bin.

\
 
 \ /
  Last update: 2019-04-01 17:44    [W:0.101 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site