Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH 5/5] Lib: sort.h: replace int size with size_t size in the swap function | Date | Mon, 1 Apr 2019 14:47:55 +0000 |
| |
From: gregkh@linuxfoundation.org > Sent: 31 March 2019 11:54 ... > Yes, "int" is a very nice variable for "size", you need to explain why > it is better to use size_t here please.
Actually, on x86_64 you probably want 'unsigned int' to avoid the compiler having to generate a sign-extending register move if the value is ever used in a 64bit expression (eg an address calculation).
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |