Messages in this thread | | | From | Chris Wilson <> | Subject | Re: [PATCH v2 2/3] drm: Add a drm_gem_objects_lookup helper | Date | Mon, 01 Apr 2019 14:48:16 +0100 |
| |
Quoting Daniel Vetter (2019-04-01 14:06:48) > On Mon, Apr 1, 2019 at 9:47 AM Rob Herring <robh@kernel.org> wrote: > > +{ > > + int i, ret = 0; > > + struct drm_gem_object *obj; > > + > > + spin_lock(&filp->table_lock); > > + > > + for (i = 0; i < count; i++) { > > + /* Check if we currently have a reference on the object */ > > + obj = idr_find(&filp->object_idr, handle[i]); > > + if (!obj) { > > + ret = -ENOENT;
Unwind previous drm_gem_object_get(), the caller has no idea how many were processed before the error. -Chris
| |