Messages in this thread | | | Subject | Re: [PATCH] video/macfb: Remove redundant code | From | Bartlomiej Zolnierkiewicz <> | Date | Mon, 1 Apr 2019 13:52:50 +0200 |
| |
On 02/15/2019 09:25 AM, Geert Uytterhoeven wrote: > On Fri, Feb 15, 2019 at 3:19 AM Finn Thain <fthain@telegraphics.com.au> wrote: >> The value of info->var.bits_per_pixel get checked in macfb_setcolreg(). >> Remove additional checks as they are redundant. >> >> macfb_defined.activate gets initialized to FB_ACTIVATE_NOW by the struct >> initializer. Remove redundant assignments. >> >> macfb_defined.bits_per_pixel, .width and .height all get assigned >> unconditionally. Remove redundant initializers. >> >> Cc: linux-m68k@lists.linux-m68k.org >> Tested-by: Stan Johnson <userm57@yahoo.com> >> Signed-off-by: Finn Thain <fthain@telegraphics.com.au> > > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Patch queued for v5.2, thanks.
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
| |