Messages in this thread | | | Date | Mon, 01 Apr 2019 17:52:34 +0800 | From | lifonghsu <> | Subject | Re: net: fix routing encapsulated packets when binding a socket to a tunnel interface |
| |
David Miller 於 2019-04-01 14:01 寫到: > From: lifonghsu <lifonghsu@synology.com> > Date: Mon, 01 Apr 2019 11:00:22 +0800 > >> Since we are not sure whether there is any code referring to the >> value of skb_iff in transmit site or not, it is risky to set an >> invalid interface > > If you are no confident in how the value is used on TX, then I can't > consider your change with confidence either. > > Think about what you are saying to me here. You basically do not know > whether you are adding a bug or not.
Indeed, we are not confident about the commit. Please drop it for now. Thank you for help review the commit.
| |