lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 032/146] net: mii: Fix PAUSE cap advertisement from linkmode_adv_to_lcl_adv_t() helper
    Date
    5.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Claudiu Manoil <claudiu.manoil@nxp.com>

    [ Upstream commit 7f07e5f1f778605e98cf2156d4db1ff3a3a1a74a ]

    With a recent link mode advertisement code update this helper
    providing local pause capability translation used for flow
    control link mode negotiation got broken.
    For eth drivers using this helper, the issue is apparent only
    if either PAUSE or ASYM_PAUSE is being advertised.

    Fixes: 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode")
    Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    include/linux/mii.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/include/linux/mii.h
    +++ b/include/linux/mii.h
    @@ -469,7 +469,7 @@ static inline u32 linkmode_adv_to_lcl_ad
    if (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
    advertising))
    lcl_adv |= ADVERTISE_PAUSE_CAP;
    - if (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
    + if (linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
    advertising))
    lcl_adv |= ADVERTISE_PAUSE_ASYM;


    \
     
     \ /
      Last update: 2019-04-01 20:12    [W:2.771 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site