lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 025/131] kbuild: setlocalversion: print error to STDERR
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Wolfram Sang <wsa@the-dreams.de>

    commit 78283edf2c01c38eb840a3de5ffd18fe2992ab64 upstream.

    I tried to use 'make O=...' from an unclean source tree. This triggered
    the error path of setlocalversion. But by printing to STDOUT, it created
    a broken localversion which then caused another (unrelated) error:

    "4.7.0-rc2Error: kernelrelease not valid - run make prepare to update it" exceeds 64 characters

    After printing to STDERR, the true build error gets displayed later:

    /home/wsa/Kernel/linux is not clean, please run 'make mrproper'
    in the '/home/wsa/Kernel/linux' directory.

    Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
    Signed-off-by: Michal Marek <mmarek@suse.com>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    scripts/setlocalversion | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/scripts/setlocalversion
    +++ b/scripts/setlocalversion
    @@ -143,7 +143,7 @@ fi
    if test -e include/config/auto.conf; then
    . include/config/auto.conf
    else
    - echo "Error: kernelrelease not valid - run 'make prepare' to update it"
    + echo "Error: kernelrelease not valid - run 'make prepare' to update it" >&2
    exit 1
    fi


    \
     
     \ /
      Last update: 2019-04-01 20:09    [W:2.192 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site