lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 047/134] btrfs: dont report readahead errors and dont update statistics
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: David Sterba <dsterba@suse.com>

    commit 0cc068e6ee59c1fffbfa977d8bf868b7551d80ac upstream.

    As readahead is an optimization, all errors are usually filtered out,
    but still properly handled when the real read call is done. The commit
    5e9d398240b2 ("btrfs: readpages() should submit IO as read-ahead") added
    REQ_RAHEAD to readpages() because that's only used for readahead
    (despite what one would expect from the callback name).

    This causes a flood of messages and inflated read error stats, so skip
    reporting in case it's readahead.

    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=202403
    Reported-by: LimeTech <tomm@lime-technology.com>
    Fixes: 5e9d398240b2 ("btrfs: readpages() should submit IO as read-ahead")
    CC: stable@vger.kernel.org # 4.19+
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/btrfs/volumes.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/btrfs/volumes.c
    +++ b/fs/btrfs/volumes.c
    @@ -6051,7 +6051,7 @@ static void btrfs_end_bio(struct bio *bi
    if (bio_op(bio) == REQ_OP_WRITE)
    btrfs_dev_stat_inc_and_print(dev,
    BTRFS_DEV_STAT_WRITE_ERRS);
    - else
    + else if (!(bio->bi_opf & REQ_RAHEAD))
    btrfs_dev_stat_inc_and_print(dev,
    BTRFS_DEV_STAT_READ_ERRS);
    if (bio->bi_opf & REQ_PREFLUSH)

    \
     
     \ /
      Last update: 2019-04-01 20:03    [W:4.076 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site