lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 080/134] tty: serial: qcom_geni_serial: Initialize baud in qcom_geni_console_setup
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nathan Chancellor <natechancellor@gmail.com>

    commit c5cbc78acf693f5605d4a85b1327fa7933daf092 upstream.

    When building with -Wsometimes-uninitialized, Clang warns:

    drivers/tty/serial/qcom_geni_serial.c:1079:6: warning: variable 'baud'
    is used uninitialized whenever 'if' condition is false
    [-Wsometimes-uninitialized]

    It's not wrong; when options is NULL, baud has no default value. Use
    9600 as that is a sane default.

    Link: https://github.com/ClangBuiltLinux/linux/issues/395
    Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
    Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/tty/serial/qcom_geni_serial.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/tty/serial/qcom_geni_serial.c
    +++ b/drivers/tty/serial/qcom_geni_serial.c
    @@ -1052,7 +1052,7 @@ static int __init qcom_geni_console_setu
    {
    struct uart_port *uport;
    struct qcom_geni_serial_port *port;
    - int baud;
    + int baud = 9600;
    int bits = 8;
    int parity = 'n';
    int flow = 'n';

    \
     
     \ /
      Last update: 2019-04-01 20:02    [W:4.570 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site