lkml.org 
[lkml]   [2019]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] amba: Take device out of reset before reading pid and cid values
On Sat, Mar 9, 2019 at 2:59 AM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:

> For the AMBA Primecell devices having the reset lines wired, it is
> necessary to take them out of reset before reading the pid and cid values.
> Earlier we were dependent on the bootloader to do this but a more cleaner
> approach would be to do it in the kernel itself. Hence, this commit
> deasserts the reset line just before reading the pid and cid values.
>
> Suggested-by: Daniel Thompson <daniel.thompson@linaro.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

This looks correct to me.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

I think you can put it in Russell's patch tracker in some week.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2019-03-09 11:51    [W:0.306 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site