lkml.org 
[lkml]   [2019]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 07/15] perf tools report: Use less for scripts output
On Fri, Mar 08, 2019 at 10:47:54AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Mar 05, 2019 at 06:47:50AM -0800, Andi Kleen escreveu:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > The UI viewer for scripts output has a lot of limitations: limited size,
> > no search or save function, slow, and various other issues.
> >
> > Just use 'less' to display directly on the terminal instead.
>
> I'm ok with this, CCing Feng tho since he contributed this browser, to
> let him know.

Thanks for the note!

>
> - Arnaldo
>
> > This won't work in gtk mode, but gtk doesn't support these
> > context menus anyways. If that is ever done could use an terminal
> > for the output.
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> >

Looks good to me.

Acked-by: Feng Tang <feng.tang@intel.com>

Thanks,
Feng

\
 
 \ /
  Last update: 2019-03-09 08:51    [W:0.077 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site