Messages in this thread | | | Date | Sat, 9 Mar 2019 18:24:49 +0000 | From | Jonathan Cameron <> | Subject | Re: [PATCH] iio: proximity: as3935: fix use-after-free on device remove |
| |
On Fri, 8 Mar 2019 12:49:30 -0500 Sven Van Asbroeck <thesven73@gmail.com> wrote:
> On Fri, Mar 8, 2019 at 12:13 PM Jonathan Cameron > <jonathan.cameron@huawei.com> wrote: > > > > Your description makes it clear that there are multiple things in the patch. > > Don't do a 'while we were here' in a patch doing something else please. > > Separate patches. > > > > The proposed solution (adding devm_) fixes multiple issues, so that can stay > as a single patch, right? > > It's the 'while we're here' you'd like to see removed? Can do.
That's the one. Just the & removal. The rest makes sense in one patch as you say.
Jonathan
| |