lkml.org 
[lkml]   [2019]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/20] objtool: Set insn->func for alternatives
On Thu, Mar 07, 2019 at 12:45:23PM +0100, Peter Zijlstra wrote:
> Make sure we set the function association for alternative instruction
> sequences; they are after all still part of the function.

Can you also say _why_? I presume it's so the warning messages will be
saner.

>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
> tools/objtool/check.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -695,6 +695,7 @@ static int handle_group_alt(struct objto
> last_new_insn = insn;
>
> insn->ignore = orig_insn->ignore_alts;
> + insn->func = orig_insn->func;
>
> if (insn->type != INSN_JUMP_CONDITIONAL &&
> insn->type != INSN_JUMP_UNCONDITIONAL)
>
>

--
Josh

\
 
 \ /
  Last update: 2019-03-08 20:17    [W:0.414 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site