Messages in this thread | | | Date | Fri, 8 Mar 2019 15:52:03 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH] i2c: mediatek: modify threshold passed to i2c_get_dma_safe_msg_buf() |
| |
> > I just checked this issue again and concluded that both are reasonable, > > the suggestion from me below with the adapter quirk AND your original > > patch setting the threshold to 1. With my suggestion the core will > > prevent 0-length messages. But still, we should set the threshold to 1 > > because 0 is a value the HW is not capable of. > > > I think quirk might be better, since mediatek said they might have some ICs > that can handle zero-length transfer in the future, so flags might be > more clear if they want to restore functionality.
But I guess you don't want to do the zero-length transfer with DMA then? With that in mind, raising the threshold still makes sense to me.
[unhandled content-type:application/pgp-signature]
| |