Messages in this thread | | | Subject | Re: [PATCH v1 4/5] scripts: checkpatch.pl: don't complain that debian/rules is executable | From | Joe Perches <> | Date | Fri, 08 Mar 2019 06:13:52 -0800 |
| |
On Fri, 2019-03-08 at 13:44 +0100, Enrico Weigelt, metux IT consult wrote: > checkpatch.pl complains when adding executable "debian/rules", > obviously a false alarm. Therefore add an exception for that.
This is predicated on a debian/ directory actually being added to the generic kernel tree.
I'm not sure that's a good idea.
As debian/ does not currently exist in the generic kernel source, I think this can be kept locally in their tree if they choose.
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -2576,6 +2576,7 @@ sub process { > if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) { > my $permhere = $here . "FILE: $realfile\n"; > if ($realfile !~ m@scripts/@ && > + $realfile !~ "debian/rules" && > $realfile !~ /\.(py|pl|awk|sh)$/) { > ERROR("EXECUTE_PERMISSIONS", > "do not set execute permissions for source files\n" . $permhere);
| |