lkml.org 
[lkml]   [2019]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.20 15/76] staging: android: ion: fix sys heap pools gfp_flags
    Date
    4.20-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Qing Xia <saberlily.xia@hisilicon.com>

    commit 9bcf065e28122588a6cbee08cf847826dacbb438 upstream.

    In the first loop, gfp_flags will be modified to high_order_gfp_flags,
    and there will be no chance to change back to low_order_gfp_flags.

    Fixes: e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc")
    Signed-off-by: Qing Xia <saberlily.xia@hisilicon.com>
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Jing Xia <jing.xia@unisoc.com>
    Reviewed-by: Yuming Han <yuming.han@unisoc.com>
    Reviewed-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
    Reviewed-by: Orson Zhai <orson.zhai@unisoc.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/android/ion/ion_system_heap.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/staging/android/ion/ion_system_heap.c
    +++ b/drivers/staging/android/ion/ion_system_heap.c
    @@ -224,10 +224,10 @@ static void ion_system_heap_destroy_pool
    static int ion_system_heap_create_pools(struct ion_page_pool **pools)
    {
    int i;
    - gfp_t gfp_flags = low_order_gfp_flags;

    for (i = 0; i < NUM_ORDERS; i++) {
    struct ion_page_pool *pool;
    + gfp_t gfp_flags = low_order_gfp_flags;

    if (orders[i] > 4)
    gfp_flags = high_order_gfp_flags;

    \
     
     \ /
      Last update: 2019-03-08 14:08    [W:4.436 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site