lkml.org 
[lkml]   [2019]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.20 59/76] net: sched: act_tunnel_key: fix NULL pointer dereference during init
    Date
    4.20-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Vlad Buslov <vladbu@mellanox.com>

    [ Upstream commit a3df633a3c92bb96b06552c3f828d7c267774379 ]

    Metadata pointer is only initialized for action TCA_TUNNEL_KEY_ACT_SET, but
    it is unconditionally dereferenced in tunnel_key_init() error handler.
    Verify that metadata pointer is not NULL before dereferencing it in
    tunnel_key_init error handling code.

    Fixes: ee28bb56ac5b ("net/sched: fix memory leak in act_tunnel_key_init()")
    Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
    Reviewed-by: Davide Caratti <dcaratti@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/sched/act_tunnel_key.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/net/sched/act_tunnel_key.c
    +++ b/net/sched/act_tunnel_key.c
    @@ -377,7 +377,8 @@ static int tunnel_key_init(struct net *n
    return ret;

    release_tun_meta:
    - dst_release(&metadata->dst);
    + if (metadata)
    + dst_release(&metadata->dst);

    err_out:
    if (exists)

    \
     
     \ /
      Last update: 2019-03-08 14:06    [W:4.180 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site