lkml.org 
[lkml]   [2019]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 09/46] staging: erofs: fix memleak of inodes shared xattr array
    Date
    5.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sheng Yong <shengyong1@huawei.com>

    commit 3b1b5291f79d040d549d7c746669fc30e8045b9b upstream.

    If it fails to read a shared xattr page, the inode's shared xattr array
    is not freed. The next time the inode's xattr is accessed, the previously
    allocated array is leaked.

    Signed-off-by: Sheng Yong <shengyong1@huawei.com>
    Fixes: b17500a0fdba ("staging: erofs: introduce xattr & acl support")
    Cc: <stable@vger.kernel.org> # 4.19+
    Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/erofs/xattr.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/staging/erofs/xattr.c
    +++ b/drivers/staging/erofs/xattr.c
    @@ -111,8 +111,11 @@ static int init_inode_xattrs(struct inod

    it.page = erofs_get_meta_page(sb,
    ++it.blkaddr, S_ISDIR(inode->i_mode));
    - if (IS_ERR(it.page))
    + if (IS_ERR(it.page)) {
    + kfree(vi->xattr_shared_xattrs);
    + vi->xattr_shared_xattrs = NULL;
    return PTR_ERR(it.page);
    + }

    it.kaddr = kmap_atomic(it.page);
    atomic_map = true;

    \
     
     \ /
      Last update: 2019-03-08 13:53    [W:4.433 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site