Messages in this thread | | | From | Alexey Budankov <> | Subject | Re: [PATCH v5 09/10] perf inject: enable COMPRESSED records decompression | Date | Thu, 7 Mar 2019 11:28:17 +0300 |
| |
On 05.03.2019 15:26, Jiri Olsa wrote: > On Fri, Mar 01, 2019 at 07:07:49PM +0300, Alexey Budankov wrote: >> >> Initialized decompression API so COMPRESSED record would be >> decompressed into the resulting output data file. >> >> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com> >> --- >> tools/perf/builtin-inject.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c >> index 24086b7f1b14..8e0e06d3edfc 100644 >> --- a/tools/perf/builtin-inject.c >> +++ b/tools/perf/builtin-inject.c >> @@ -837,6 +837,9 @@ int cmd_inject(int argc, const char **argv) >> if (inject.session == NULL) >> return -1; >> >> + if (zstd_init(&(inject.session->zstd_data), 0) < 0) >> + pr_warning("Decompression initialization failed.\n"); > > hum, I wonder we should put this inside perf_session__new/perf_session__delete
comp_level parameter passing would extend the signature of __new()
struct perf_session *perf_session__new(struct perf_data *data, bool repipe, struct perf_tool *tool, int comp_level)
~Alexey
> > jirka > >> + >> if (inject.build_ids) { >> /* >> * to make sure the mmap records are ordered correctly >> @@ -867,6 +870,7 @@ int cmd_inject(int argc, const char **argv) >> ret = __cmd_inject(&inject); >> >> out_delete: >> + zstd_fini(&(inject.session->zstd_data)); >> perf_session__delete(inject.session); >> return ret; >> } >> -- >> 2.20.1 >> >
| |