lkml.org 
[lkml]   [2019]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 18/20] objtool: Add UACCESS validation
    On Thu, Mar 7, 2019 at 9:41 AM Peter Zijlstra <peterz@infradead.org> wrote:
    > >
    > > What's the call site that made you go "just add __memset() to the list"?
    >
    > __asan_{,un}poinson_stack_memory()
    > kasan_{,un}poison_shadow()
    > __memset()

    Ugh. I think I almost just agree with your decision to just let that
    memset go unchecked.

    I'm not saying it's right, but it doesn't seem to be a fight worth fighting.

    Again, maybe we could avoid the static checking entirely for the
    complex configs, and just make preempt_schedule() not do it for AC
    regions.

    Because AC vs KASAN in general ends up smelling like "not a fight
    worth fighting" to me. You've done a herculean job, but..

    Linus

    \
     
     \ /
      Last update: 2019-03-07 19:03    [W:2.755 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site