lkml.org 
[lkml]   [2019]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] net: stmmac: Avoid sometimes uninitialized Clang warnings
On Thu, Mar 7, 2019 at 9:49 AM David Miller <davem@davemloft.net> wrote:
>
> From: Nathan Chancellor <natechancellor@gmail.com>
> Date: Thu, 7 Mar 2019 09:21:01 -0700
>
> > @@ -565,7 +565,7 @@ static int stmmac_hwtstamp_set(struct net_device *dev, struct ifreq *ifr)
> > u32 ts_master_en = 0;
> > u32 ts_event_en = 0;
> > u32 value = 0;
> > - u32 sec_inc;
> > + u32 sec_inc = 0;
> > bool xmac;
>
> Please don't break the reverse christmas tree ordering here, thank you.

Every codebase has its own unique code style. *wonders how
clang-format could or could not handle that rule*

Thanks for sending the patch Nathan; if you could resend with the
declaration order changed so that the line width decreases going down
in the order, you can add my Reviewed-by tag.
--
Thanks,
~Nick Desaulniers

\
 
 \ /
  Last update: 2019-03-07 18:55    [W:1.973 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site