lkml.org 
[lkml]   [2019]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 00/20] objtool: UACCESS validation v3
    On Thu, Mar 7, 2019 at 8:47 AM Josh Poimboeuf <jpoimboe@redhat.com> wrote:
    >
    > This "fixes" it, and also seems to help -Os make much code:

    Yeah, considering that this __trace_if() macro from hell is doing an
    'if()' on the result of that inner thing, it makes sense to *not* use
    that "looks simpler and shorter" array sequence, but depend on the
    compiler then noticing that the conditionals are the same and joining
    the two branches together.

    The compiler has to do much more work to either generate the actual
    dynamic array thing, or notice that the _index_ of the array matches
    the _conditional_ on the branch, and undo that thing.

    But that macro really is the macro from hell regardless.

    Do people really use CONFIG_PROFILE_ALL_BRANCHES?

    Linus

    \
     
     \ /
      Last update: 2019-03-07 18:02    [W:3.076 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site