lkml.org 
[lkml]   [2019]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ASoC: ams-delta: remove duplicate 'const'
    On Thu, Mar 07, 2019 at 11:10:49AM +0100, Arnd Bergmann wrote:
    > clang points out that SOC_ENUM_SINGLE_EXT_DECL() contains a 'const'
    > modifier already, so adding another one does not make it more const:
    >
    > sound/soc/ti/ams-delta.c:203:14: error: duplicate 'const' declaration specifier [-Werror,-Wduplicate-decl-specifier]
    > static const SOC_ENUM_SINGLE_EXT_DECL(ams_delta_audio_enum,
    > ^
    > include/sound/soc.h:351:2: note: expanded from macro 'SOC_ENUM_SINGLE_EXT_DECL'
    > const struct soc_enum name = SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(xtexts), xtexts)
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

    Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>

    > ---
    > sound/soc/ti/ams-delta.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/sound/soc/ti/ams-delta.c b/sound/soc/ti/ams-delta.c
    > index 4dce494dfbd3..b9611db14c86 100644
    > --- a/sound/soc/ti/ams-delta.c
    > +++ b/sound/soc/ti/ams-delta.c
    > @@ -200,7 +200,7 @@ static int ams_delta_get_audio_mode(struct snd_kcontrol *kcontrol,
    > return 0;
    > }
    >
    > -static const SOC_ENUM_SINGLE_EXT_DECL(ams_delta_audio_enum,
    > +static SOC_ENUM_SINGLE_EXT_DECL(ams_delta_audio_enum,
    > ams_delta_audio_mode);
    >
    > static const struct snd_kcontrol_new ams_delta_audio_controls[] = {
    > --
    > 2.20.0
    >

    \
     
     \ /
      Last update: 2019-03-07 16:22    [W:4.379 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site