| Date | Thu, 7 Mar 2019 14:50:06 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 07/20] x86/uaccess: Always inline force_valid_ss() |
| |
On Thu, Mar 07, 2019 at 12:45:18PM +0100, Peter Zijlstra wrote: > arch/x86/kernel/signal.o: warning: objtool: restore_sigcontext()+0x3cc: call to force_valid_ss.isra.5() with UACCESS enabled > > XXX: move the callsite out of te AC=1 region instead? > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > --- > arch/x86/kernel/signal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/x86/kernel/signal.c > +++ b/arch/x86/kernel/signal.c > @@ -71,7 +71,7 @@ > * alone. Using this generally makes no sense unless > * user_64bit_mode(regs) would return true. > */ > -static void force_valid_ss(struct pt_regs *regs) > +static __always_inline void force_valid_ss(struct pt_regs *regs) > { > u32 ar; > asm volatile ("lar %[old_ss], %[ar]\n\t"
arch/x86/kernel/signal.o: warning: objtool: do_signal()+0x384: call to frame_uc_flags.isra.0() with UACCESS enabled
@@ -441,7 +441,7 @@ static int __setup_rt_frame(int sig, str return 0; } #else /* !CONFIG_X86_32 */ -static unsigned long frame_uc_flags(struct pt_regs *regs) +static __always_inline unsigned long frame_uc_flags(struct pt_regs *regs) { unsigned long flags;
|