Messages in this thread | | | Subject | Re: [RFC PATCH V2 4/5] vhost: introduce helpers to get the size of metadata area | From | Jason Wang <> | Date | Thu, 7 Mar 2019 10:40:20 +0800 |
| |
On 2019/3/6 下午6:56, Christophe de Dinechin wrote: >> On 6 Mar 2019, at 08:18, Jason Wang<jasowang@redhat.com> wrote: >> >> Signed-off-by: Jason Wang<jasowang@redhat.com> >> --- >> drivers/vhost/vhost.c | 46 ++++++++++++++++++++++++++++------------------ >> 1 file changed, 28 insertions(+), 18 deletions(-) >> >> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c >> index 2025543..1015464 100644 >> --- a/drivers/vhost/vhost.c >> +++ b/drivers/vhost/vhost.c >> @@ -413,6 +413,27 @@ static void vhost_dev_free_iovecs(struct vhost_dev *dev) >> vhost_vq_free_iovecs(dev->vqs[i]); >> } >> >> +static size_t vhost_get_avail_size(struct vhost_virtqueue *vq, int num) > Nit: Any reason not to make `num` unsigned or size_t? >
Let me use unsigned int to match the definition of vq->num.
Thanks
| |