lkml.org 
[lkml]   [2019]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH] arm64: dts: ls1028a: add pmu dt nodes
    Date
    Hi, Shawn,

    > On Wed, Feb 27, 2019 at 09:57:52AM +0800, Alison Wang wrote:
    > > This patch adds pmu dt nodes for LS1028A.
    > >
    > > Signed-off-by: Alison Wang <alison.wang@nxp.com>
    > > ---
    > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 5 +++++
    > > 1 files changed, 5 insertions(+), 0 deletions(-)
    > >
    > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
    > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
    > > index a8cf92a..36ef9c5 100644
    > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
    > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
    > > @@ -89,6 +89,11 @@
    > > IRQ_TYPE_LEVEL_LOW)>;
    > > };
    > >
    > > + pmu {
    > > + compatible = "arm,armv8-pmuv3";
    >
    > Shouldn't we use "arm,cortex-a72-pmu" as compatible for better?
    >
    [Alison] Yes, it is better as compatible. I will change it in v2.
    Thanks.


    Best Regards,
    Alison Wang

    > Shawn
    >
    > > + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
    > > + };
    > > +
    > > gic: interrupt-controller@6000000 {
    > > compatible= "arm,gic-v3";
    > > #address-cells = <2>;
    > > --
    > > 1.7.1
    > >

    \
     
     \ /
      Last update: 2019-03-06 09:27    [W:2.602 / U:0.636 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site