Messages in this thread | | | Subject | Re: [PATCH] extcon-ptn5150: fix COMPILE_TEST dependencies | From | Chanwoo Choi <> | Date | Thu, 7 Mar 2019 09:58:05 +0900 |
| |
Hi Randy,
On 19. 3. 7. 오전 12:49, Randy Dunlap wrote: > On 3/6/19 3:08 AM, Arnd Bergmann wrote: >> The PTN5150 dependencies look like they were meant to do the >> right thing, but they actually should not allow building without >> I2C for compile testing, as that results in a Kconfig warning >> and subsequent build failure: >> >> WARNING: unmet direct dependencies detected for REGMAP_I2C >> Depends on [m]: I2C [=m] >> Selected by [y]: >> - EXTCON_PTN5150 [=y] && EXTCON [=y] && (I2C [=m] && GPIOLIB [=y] || COMPILE_TEST [=y]) >> Selected by [m]: >> - EEPROM_AT24 [=m] && I2C [=m] && SYSFS [=y] >> - KEYBOARD_CAP11XX [=m] && !UML && INPUT [=y] && INPUT_KEYBOARD [=y] && OF [=y] && I2C [=m] >> - INPUT_DRV260X_HAPTICS [=m] && !UML && INPUT_MISC [=y] && INPUT [=y] && I2C [=m] && (GPIOLIB [=y] || COMPILE_TEST [=y]) >> - ... [many others] >> >> Add parentheses around the expression so we can compile-test >> without GPIOLIB but not without I2C. >> >> Fixes: 4ed754de2d66 ("extcon: Add support for ptn5150 extcon driver") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Hi Chanwoo, > > You might want to drop my patch and use this one from Arnd instead...
Thanks for your comment. I'll do that.
> > >> --- >> drivers/extcon/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig >> index 8e17149655f0..540e8cd16ee6 100644 >> --- a/drivers/extcon/Kconfig >> +++ b/drivers/extcon/Kconfig >> @@ -116,7 +116,7 @@ config EXTCON_PALMAS >> >> config EXTCON_PTN5150 >> tristate "NXP PTN5150 CC LOGIC USB EXTCON support" >> - depends on I2C && GPIOLIB || COMPILE_TEST >> + depends on I2C && (GPIOLIB || COMPILE_TEST) >> select REGMAP_I2C >> help >> Say Y here to enable support for USB peripheral and USB host >> > >
-- Best Regards, Chanwoo Choi Samsung Electronics
| |