Messages in this thread | | | From | Arnd Bergmann <> | Date | Wed, 6 Mar 2019 21:15:13 +0100 | Subject | Re: [PATCH] EDAC, {skx|i10nm}_edac: Fix randconfig build error |
| |
On Wed, Mar 6, 2019 at 6:58 PM Luck, Tony <tony.luck@intel.com> wrote: > From: Qiuxu Zhuo <qiuxu.zhuo@intel.com> > > This seems cleaner than adding all the EXPORTs to skx_common.c > I also tried a build with the 0x8A152468-config.gz that Arnd > supplied.
It's still a bit fragile since you do something that kbuild doesn't expect with having a file in both a module and built-in code in some configurations. I'm fairly sure this version works today, but it would break the next time that file gets changed to include a reference to THIS_MODULE, or anything else that is different between built-in and modular code.
Another alternative would be to mark all symbols in this file 'static' and then include skx_common.c from the other two files. Of course that is also ugly and it increases the overall code size, so I don't see a way to win this.
Arnd
| |