Messages in this thread | | | Subject | Re: [PATCH v11] f2fs: guarantee journalled quota data by checkpoint | From | Chao Yu <> | Date | Wed, 6 Mar 2019 14:49:28 +0800 |
| |
Hi Jaegeuk,
On 2018/9/20 20:05, Chao Yu wrote: > @@ -3456,3 +3477,16 @@ > > extern void f2fs_build_fault_attr(struct f2fs_sb_info *sbi, unsigned int rate, > > #endif > #endif > + > +static inline bool is_journalled_quota(struct f2fs_sb_info *sbi) > +{ > +#ifdef CONFIG_QUOTA > + if (f2fs_sb_has_quota_ino(sbi->sb)) > + return true; > + if (F2FS_OPTION(sbi).s_qf_names[USRQUOTA] || > + F2FS_OPTION(sbi).s_qf_names[GRPQUOTA] || > + F2FS_OPTION(sbi).s_qf_names[PRJQUOTA]) > + return true; > +#endif > + return false; > +}
I checked dev branch, and found one patch we didn't send to mailing list, could you please send it out?
f2fs: fix wrong #endif
I think my quota patch caused this 'wrong #endif' issue, could you add single line comment to notice which #if the last #endif is corresponding to? so that we can avoid same mistake as quota patch made.
Thanks,
| |