Messages in this thread | | | Subject | Re: [f2fs-dev] [PATCH v2] f2fs: fix to check inline_xattr_size boundary correctly | From | Chao Yu <> | Date | Wed, 6 Mar 2019 14:32:42 +0800 |
| |
Ping,
On 2019/3/4 14:39, Chao Yu wrote: > Hi Jaegeuk, > > On 2019/2/15 0:08, Chao Yu wrote: >> --- >> v2: >> - fix lower bound check, inline xattr size should be larger than >> xattr_header's size at least. > > ... > >> + if (F2FS_OPTION(sbi).inline_xattr_size < >> + sizeof(struct f2fs_xattr_header) / sizeof(__le32) > > No sure we should set this low bound as above... now I guess original > non-zero check is enough. > > How do you think of setting inline_xattr_size range as > (0, MAX_INLINE_XATTR_SIZE]? > > Thanks, > > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > >
| |