Messages in this thread | | | From | Miguel Ojeda <> | Date | Wed, 6 Mar 2019 10:56:21 +0100 | Subject | Re: [PATCH 3/3] auxdisplay: charlcd: make backlight initial state configurable |
| |
On Fri, Mar 1, 2019 at 7:48 PM Mans Rullgard <mans@mansr.com> wrote: > > +#ifdef CONFIG_CHARLCD_BL_ON > +#define LCD_INIT_BL "\x1b[L+" > +#elif defined (CONFIG_CHARLCD_BL_FLASH)
Style nitpick: no space after "elif defined". Do you mind if I change it before sending it to linux-next? Otherwise, looks fine to me. Thanks!
CC'ing Willy in case he wants to take a look for charlcd.c
Cheers, Miguel
| |