lkml.org 
[lkml]   [2019]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] media: drxk: add a missed check of the return value of write16
On Tue, Dec 25, 2018 at 02:03:07AM -0600, Kangjie Lu wrote:
> write16() could fail. The fix inserts a check for its return value
> in case it fails.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>

Unless it is tested on the actual hardware we can't apply this. This could
introduce regressions.

Sean

> ---
> drivers/media/dvb-frontends/drxk_hard.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/drxk_hard.c b/drivers/media/dvb-frontends/drxk_hard.c
> index 84ac3f73f8fe..b7579ffae690 100644
> --- a/drivers/media/dvb-frontends/drxk_hard.c
> +++ b/drivers/media/dvb-frontends/drxk_hard.c
> @@ -6610,7 +6610,9 @@ static int drxk_get_stats(struct dvb_frontend *fe)
> if (status < 0)
> goto error;
> pkt_error_count = reg16;
> - write16(state, SCU_RAM_FEC_ACCUM_PKT_FAILURES__A, 0);
> + status = write16(state, SCU_RAM_FEC_ACCUM_PKT_FAILURES__A, 0);
> + if (status < 0)
> + goto error;
>
> post_bit_err_count *= post_bit_error_scale;
>
> --
> 2.17.2 (Apple Git-113)

\
 
 \ /
  Last update: 2019-03-05 22:26    [W:3.797 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site