This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Sun Apr 28 12:33:21 2024 >From mailfetcher Tue Mar 5 16:04:41 2019 Envelope-to: lkml@grols.ch Delivery-date: Tue, 05 Mar 2019 16:04:33 +0100 Received: from stout.grols.ch [195.201.141.146] by 72459556e3a9 with IMAP (fetchmail-6.3.26) for (single-drop); Tue, 05 Mar 2019 16:04:41 +0100 (CET) Received: from vger.kernel.org ([209.132.180.67]) by stout.grols.ch with esmtp (Exim 4.89) (envelope-from ) id 1h1BcP-0000J7-6j for lkml@grols.ch; Tue, 05 Mar 2019 16:04:33 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728410AbfCEPEb (ORCPT ); Tue, 5 Mar 2019 10:04:31 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:42010 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728407AbfCEPEb (ORCPT ); Tue, 5 Mar 2019 10:04:31 -0 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x25EwucM068210; Tue, 5 Mar 2019 15:04:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=corp-2018-07-02; bh=whALaH2FYSiHZMtoyrQE2aHUWCB9+DSN3UR8q9XLFW0=; b Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2qyh8u5wvv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Mar 2019 15:04:18 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x25F4CMs002625 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Mar 2019 15:04: Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x25F4CcT010829; Tue, 5 Mar 2019 15:04:12 GMT Received: from lap1 (/77.138.186.148) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 05 Mar 2019 07:04:11 -0800 Date: Tue, 5 Mar 2019 17:04:06 +0200 From: Yuval Shaia To: Ira Weiny Cc: john.hubbard@gmail.com, linux-mm@kvack.org, Andrew Morton , LKML , John Hubbard , Leon Romanovsky , Jason Gunthorpe References: <20190304194645.10422-1-jhubbard@nvidia.com> <20190304194645.10422-2-jhubbard@nvidia.com> <20190304115814.GE30058@iweiny-DESK2.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190304115814.GE30058@iweiny-DESK2.sc.intel.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9185 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancou Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org Received-SPF: none client-ip=209.132.180.67; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org X-Spam-Score: -3.4 X-Spam-Score-Bar: --- X-Spam-Action: no action X-Spam-Report: Action: no action Symbol: ARC_NA(0.00) Symbol: R_DKIM_ALLOW(-0.20) Symbol: BAYES_HAM(-3.00) Symbol: FROM_HAS_DN(0.00) Symbol: TO_DN_SOME(0.00) Symbol: PRECEDENCE_BULK(0.00) Symbol: TAGGED_RCPT(0.00) Symbol: MIME_GOOD(-0.10) Symbol: FORGED_SENDER_MAILLIST On Mon, Mar 04, 2019 at 03:58:15AM -0800, Ira Weiny wrote: > On Mon, Mar 04, 2019 at 11:46:45AM -0800, john.hubbard@gmail.com wrote: > > From: John Hubbard > >=20 > > 1. Bug fix: fix an off by one error in the code that > > cleans up if it fails to dma-map a page, after having > > done a get_user_pages_remote() on a range of pages. > >=20 > > 2. Refinement: for that same cleanup code, release_pages() > > is better than put_page() in a loop. > >=20 > > Cc: Leon Romanovsky > > Cc: Ira Weiny > > Cc: Jason Gunthorpe > > Cc: Andrew Morton > > Cc: Doug Ledford > > Cc: linux-rdma@vger.kernel.org > > Cc: linux-mm@kvack.org > > Signed-off-by: John Hubbard >=20 > I meant... >=20 > Reviewed-by: Ira Weiny >=20 > just a bit too quick on the keyboard before lunch... ;-) >=20 > Ira I have this mapping in vimrc so i just have to do shift+! map ! o=0DReviewed-by: Yuval Shaia =0D=1B >=20 >=20 > > --- > > drivers/infiniband/core/umem_odp.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > >=20 > > diff --git a/drivers/infiniband/core/umem_odp.c b/drivers/infiniband/co= re/umem_odp.c > > index acb882f279cb..d45735b02e07 100644 > > --- a/drivers/infiniband/core/umem_odp.c > > +++ b/drivers/infiniband/core/umem_odp.c > > @@ -40,6 +40,7 @@ > > #include > > #include > > #include > > +#include > > =20 > > #include > > #include > > @@ -684,9 +685,11 @@ int ib_umem_odp_map_dma_pages(struct ib_umem_odp *= umem_odp, u64 user_virt, > > mutex_unlock(&umem_odp->umem_mutex); > > =20 > > if (ret < 0) { > > - /* Release left over pages when handling errors. */ > > - for (++j; j < npages; ++j) > > - put_page(local_page_list[j]); > > + /* > > + * Release pages, starting at the the first page > > + * that experienced an error. > > + */ > > + release_pages(&local_page_list[j], npages - j); > > break; > > } > > } > > --=20 > > 2.21.0 > >=20