Messages in this thread | | | From | Yash Shah <> | Date | Tue, 5 Mar 2019 13:55:41 +0530 | Subject | Re: [PATCH v8 0/2] PWM support for HiFive Unleashed |
| |
On Mon, Mar 4, 2019 at 4:39 PM Andreas Schwab <schwab@suse.de> wrote: > > On Mär 01 2019, Yash Shah <yash.shah@sifive.com> wrote: > > > This patch series adds a PWM driver and DT documentation > > for HiFive Unleashed board. The patches are mostly based on > > Wesley's patch. > > That doesn't appear to work with the heartbeat trigger, the led doesn't > flash.
Make sure you modify the DTS file since with this patch the period is now passed through the conventional way. Example: pwmleds { compatible = "pwm-leds"; heartbeat { pwms = <&L45 0 100000 0>; max-brightness = <255>; linux,default-trigger = "heartbeat"; }; };
I have tested the heartbeat trigger on HiFive Unleashed board and it's working with this PWM patch.
> > Andreas. > > -- > Andreas Schwab, SUSE Labs, schwab@suse.de > GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 > "And now for something completely different."
| |