lkml.org 
[lkml]   [2019]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] media: staging/intel-ipu3: mark PM function as __maybe_unused
    Date
    The imgu_rpm_dummy_cb() looks like an API misuse that is explained
    in the comment above it. Aside from that, it also causes a warning
    when power management support is disabled:

    drivers/staging/media/ipu3/ipu3.c:794:12: error: 'imgu_rpm_dummy_cb' defined but not used [-Werror=unused-function]

    The warning is at least easy to fix by marking the function as
    __maybe_unused.

    Fixes: 7fc7af649ca7 ("media: staging/intel-ipu3: Add imgu top level pci device driver")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    drivers/staging/media/ipu3/ipu3.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/media/ipu3/ipu3.c b/drivers/staging/media/ipu3/ipu3.c
    index d575ac78c8f0..d00d26264c37 100644
    --- a/drivers/staging/media/ipu3/ipu3.c
    +++ b/drivers/staging/media/ipu3/ipu3.c
    @@ -791,7 +791,7 @@ static int __maybe_unused imgu_resume(struct device *dev)
    * PCI rpm framework checks the existence of driver rpm callbacks.
    * Place a dummy callback here to avoid rpm going into error state.
    */
    -static int imgu_rpm_dummy_cb(struct device *dev)
    +static __maybe_unused int imgu_rpm_dummy_cb(struct device *dev)
    {
    return 0;
    }
    --
    2.20.0
    \
     
     \ /
      Last update: 2019-03-04 21:29    [W:6.412 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site