Messages in this thread | | | Date | Mon, 04 Mar 2019 19:22:22 +0100 | From | Paul Cercueil <> | Subject | Re: [PATCH v4 1/9] dt-bindings: mtd: ingenic: Add compatible strings for JZ4740 and JZ4725B |
| |
Hi Miquel,
On Mon, Mar 4, 2019 at 10:45 AM, Miquel Raynal <miquel.raynal@bootlin.com> wrote: > Hi Paul, > > Paul Cercueil <paul@crapouillou.net <mailto:paul@crapouillou.net>> > wrote on Sat, 9 Feb 2019 16:22:57 > -0300: > >> Add compatible strings to probe the jz4780-nand and jz4780-bch >> drivers >> from devicetree on the JZ4725B and JZ4740 SoCs from Ingenic. >> >> Signed-off-by: Paul Cercueil <paul@crapouillou.net >> <mailto:paul@crapouillou.net>> >> --- >> >> Changes: >> >> v2: - Change 'ingenic,jz4725b-nand' compatible string to >> 'ingenic,jz4740-nand' to reflect driver change >> - Add 'ingenic,jz4740-bch' compatible string >> - Document 'ingenic,oob-layout' property >> >> v3: - Removed 'ingenic,oob-layout' property >> - Update compatible strings to what the driver supports >> >> v4: No change >> >> Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt | 10 >> ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt >> b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt >> index 29ea5853ca91..a5b940f18bf6 100644 >> --- a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt >> +++ b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt >> @@ -6,7 +6,10 @@ memory-controllers/ingenic,jz4780-nemc.txt), and >> thus NAND device nodes must >> be children of the NEMC node. >> >> Required NAND controller device properties: >> -- compatible: Should be set to "ingenic,jz4780-nand". >> +- compatible: Should be one of: >> + * ingenic,jz4740-nand >> + * ingenic,jz4725b-nand >> + * ingenic,jz4780-nand > > Wouldn't "-nand-controller" suffix be better? Of course in the driver > you should still check for jz4780-nand.
So I would be compatible with: * ingenic,jz4740-nand-controller * ingenic,jz4725b-nand-controller * ingenic,jz4780-nand ?
>> - reg: For each bank with a NAND chip attached, should specify a >> bank number, >> an offset of 0 and a size of 0x1000000 (i.e. the whole NEMC >> bank). >> >> @@ -72,7 +75,10 @@ NAND devices. The following is a description of >> the device properties for a >> BCH controller. >> >> Required BCH properties: >> -- compatible: Should be set to "ingenic,jz4780-bch". >> +- compatible: Should be one of: >> + * ingenic,jz4740-ecc >> + * ingenic,jz4725b-bch >> + * ingenic,jz4780-bch >> - reg: Should specify the BCH controller registers location and >> length. >> - clocks: Clock for the BCH controller. >> > > Thanks, > Miquèl
| |