Messages in this thread | | | Date | Mon, 4 Mar 2019 14:46:06 +0000 | From | Sudeep Holla <> | Subject | Re: [PATCH 12/15] ARM: vexpress: fix a leaked reference by addingmissing of_node_put |
| |
On Fri, Mar 01, 2019 at 04:56:53PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-vexpress/dcscb.c:150:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. > ./arch/arm/mach-vexpress/dcscb.c:160:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. > ./arch/arm/mach-vexpress/dcscb.c:171:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 145, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com>
Looks good, assuming you want to take this as a series. Please shout if you want us to take this.
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
-- Regards, Sudeep
| |