Messages in this thread | | | Date | Mon, 4 Mar 2019 10:46:43 +0000 | From | Sudeep Holla <> | Subject | Re: [PATCH 2/6] ptrace: introduce ptrace_syscall_enter to consolidate PTRACE_SYSEMU handling |
| |
On Mon, Mar 04, 2019 at 08:03:47AM +0000, Haibo Xu (Arm Technology China) wrote: > On 2019/3/1 2:32, Sudeep Holla wrote: > > Currently each architecture handles PTRACE_SYSEMU in very similar way. > > It's completely arch independent and can be handled in the code helping > > to consolidate PTRACE_SYSEMU handling. > > > > Let's introduce a hook 'ptrace_syscall_enter' that arch specific syscall > > entry code can call. > > > > The 'ptrace_syscall_enter' is dedicated for PTRACE_SYSEMU flag, > So I suggest to rename the function to something like 'ptrace_syscall_emu_enter". >
I am fine to rename.
> > +/* > > + * Hook to check and report for PTRACE_SYSEMU, can be called from arch > > + * arch syscall entry code > > + */ > > +long ptrace_syscall_enter(struct pt_regs *regs) > > +{ > > +#ifdef TIF_SYSCALL_EMU > > + if (test_thread_flag(TIF_SYSCALL_EMU)) { > > + if (tracehook_report_syscall_entry(regs)); > > Shall we remove the semi-colon at end of the above line? >
Added intentionally to keep GCC happy.
-- Regards, Sudeep
| |